refac _has_update parser, use tpl comparison

This commit is contained in:
Simon 2023-11-22 12:46:09 +07:00
parent cfb15c1a78
commit 43708ee2a3
No known key found for this signature in database
GPG Key ID: 2C15AA5E89985DD4
1 changed files with 6 additions and 8 deletions

View File

@ -277,12 +277,12 @@ class ReleaseVersion:
"""check version""" """check version"""
print(f"[{self.local_version}]: look for updates") print(f"[{self.local_version}]: look for updates")
self.get_remote_version() self.get_remote_version()
new_version, is_breaking = self._has_update() new_version = self._has_update()
if new_version: if new_version:
message = { message = {
"status": True, "status": True,
"version": new_version, "version": new_version,
"is_breaking": is_breaking, "is_breaking": self.is_breaking,
} }
RedisArchivist().set_message(self.NEW_KEY, message) RedisArchivist().set_message(self.NEW_KEY, message)
print(f"[{self.local_version}]: found new version {new_version}") print(f"[{self.local_version}]: found new version {new_version}")
@ -301,15 +301,13 @@ class ReleaseVersion:
def _has_update(self): def _has_update(self):
"""check if there is an update""" """check if there is an update"""
for idx, number in enumerate(self.local_version): if self.remote_version > self.local_version:
is_newer = self.remote_version[idx] > number return self.remote_version
if is_newer:
return self.response["release_version"], self.is_breaking
if self.is_unstable and self.local_version == self.remote_version: if self.is_unstable and self.local_version == self.remote_version:
return self.response["release_version"], self.is_breaking return self.remote_version
return False, False return False
@staticmethod @staticmethod
def _parse_version(version): def _parse_version(version):