From a8a7edb93e90209858726fb77d9604926379c708 Mon Sep 17 00:00:00 2001 From: simon Date: Thu, 14 Apr 2022 15:53:10 +0700 Subject: [PATCH 1/2] skip subtilte events without duration, #196 --- tubearchivist/home/src/index/video.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tubearchivist/home/src/index/video.py b/tubearchivist/home/src/index/video.py index 8866118..a58a0cb 100644 --- a/tubearchivist/home/src/index/video.py +++ b/tubearchivist/home/src/index/video.py @@ -170,6 +170,11 @@ class SubtitleParser: self.all_cues = [] for idx, event in enumerate(all_events): + if "dDurationMs" not in event: + # some events won't have a duration + print(f"failed to parse event without duration: {event}") + continue + cue = { "start": self._ms_conv(event["tStartMs"]), "end": self._ms_conv(event["tStartMs"] + event["dDurationMs"]), From fd00369859ce55d45b95a4bad41c47f99c67f76b Mon Sep 17 00:00:00 2001 From: simon Date: Thu, 14 Apr 2022 16:04:21 +0700 Subject: [PATCH 2/2] fix last page pagination link building error, #221 --- tubearchivist/home/src/index/generic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tubearchivist/home/src/index/generic.py b/tubearchivist/home/src/index/generic.py index 2823533..dcff82b 100644 --- a/tubearchivist/home/src/index/generic.py +++ b/tubearchivist/home/src/index/generic.py @@ -133,7 +133,7 @@ class Pagination: """validate pagination with total_hits after making api call""" page_get = self.page_get max_pages = math.ceil(total_hits / self.page_size) - if total_hits > 10000: + if total_hits >= 10000: # es returns maximal 10000 results self.pagination["max_hits"] = True max_pages = max_pages - 1